First step towards a refactor - Githubissues

reproducible-notebooks / ERDDAP_timeseries_explorer

Simple interactive ERDDAP time series explorer using Jupyter Widgets

MIT License

6 stars 4 forks source link

First step towards a refactor #14

Closed ocefpaf closed 3 years ago

ocefpaf commented 3 years ago

We need to split the code that fetches the data and the that creates that app. Before we do that let's clean the code up a little.

[x] remove duplication and aggregate the multiple servers in a dict that can be used later in the app
[x] remove left-over commented code
[x] check with flake8
[x] blacken the code

apkrelling commented 3 years ago

PR #19 should complete the first task.

apkrelling commented 3 years ago

I added some things on PR #19 to improve readability.

apkrelling commented 3 years ago

PR #20 should solve the third and fourth tasks.

ocefpaf commented 3 years ago

We need to re-issue #19, close this one, and move to the next step!

apkrelling commented 3 years ago

I'll close #19 without merging to master, since its purpose was accomplished by #22. Also, I'll get a new PR to complete the second task of this issue (remove left-over commented code).

apkrelling commented 3 years ago

PR #23 completes the removal of left-over commented code.