search

reproducible-notebooks / ERDDAP_timeseries_explorer

Simple interactive ERDDAP time series explorer using Jupyter Widgets
MIT License
6 stars 4 forks source link

Refactor #32

Closed apkrelling closed 3 years ago

apkrelling commented 3 years ago

I turned quite a few commands in the original notebook into functions, grouped them, and moved the majority of the content of the original notebook into three files: config.py, plots.py and widgets.py. Those .py files are all in the erddap_app folder. So now the notebook is, for the most part, just calling these functions. The map_click_handler function is not working yet.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ocefpaf commented 3 years ago

I applied the updated pre-commit to this PR but there are a few failing that requires our attention. To run it locally you will need install pre-commit (conda install pre-commit) and run pre-commit run --all-files in the repository. (That is what the CI service do BTW.)

ocefpaf commented 3 years ago

Merging this so we can address the remaining checks for another PR.

apkrelling commented 3 years ago

Merging this so we can address the remaining checks for another PR.

Solved in PR #33