search

reproducible-notebooks / ERDDAP_timeseries_explorer

Simple interactive ERDDAP time series explorer using Jupyter Widgets
MIT License
6 stars 4 forks source link

put most of the code into modules #36

Closed apkrelling closed 3 years ago

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

apkrelling commented 3 years ago

pre-commit for layout.py raises

undefined name 'display'

display(form) is necessary for the plots made by layout.py to appear on the notebook.

That is the only problem with the file. Locally I overran the pre-commit. @ocefpaf any suggestions on a better/nicer/more correct way to do this? Maybe change something in the pre-commit settings?

ocefpaf commented 3 years ago

Is that the IPython.display? Can we import it to make a defined func?

apkrelling commented 3 years ago

Is that the IPython.display? Can we import it to make a defined func?

Yes and yes. Now display is a defined func.