search

reproducible-notebooks / ERDDAP_timeseries_explorer

Simple interactive ERDDAP time series explorer using Jupyter Widgets
MIT License
6 stars 4 forks source link

Get binder working again #8

Closed rsignell-usgs closed 3 years ago

rsignell-usgs commented 3 years ago

Currently if I click the binder link and run the notebook it fails loading some erddapy stuff. I'm guessing it moved.

2020-11-17_10-25-36

@apkrelling , hoping you can take a look, perhaps with the help of @ocefpaf

ocefpaf commented 3 years ago

The author of erddapy made a major refactor and released a minor version instead of major. Quite the amateurish package and we should not use it :stuck_out_tongue_closed_eyes:

@apkrelling most of the relevant changes are in https://github.com/ioos/erddapy/pull/145. The submodules moved a bit and utilities no longer exists. So we need to import urlopen from erddapy.url_handling now. Do you want to send a PR to fix that?

apkrelling commented 3 years ago

Fixed in c15e11cc607ee0ceffc8b47ff163531ff26039ae (.py) and 14508b7ef04afd5c990f32e7f3ba9501eab479d9 (.ipynb).