republik / app

The app: a thin wrapper for persistent auth, app store presence, notification, background audio and convenience.
https://www.republik.ch/app
Other
11 stars 2 forks source link

App Bug update 2.0.1 #251

Closed ovbm closed 3 years ago

ovbm commented 3 years ago

fixes #249, fixes #250, fixes #207, fixes #248, fixes #247, fixes #246, fixes #241, fixes #240

ovbm commented 3 years ago

@tpreusse A lot of the file changes are due to the react-native upgrade. most relevant for review:

I was able to build and run the app on both ios simulator and android simulators. Would be good to make a test flight version. I'm currently blocked because of a weird node-related bug, which prevents me from building the ios bundle with the command line (only works via xcode, see: https://github.com/facebook/react-native/issues/31259 for details). Was able to fix the issue (it seems to be a local node issue)

ovbm commented 3 years ago

Tested fullscreen video and gallery. Working as intended on my device.

ScrollBars:

Screenshot_20210409-162709_Republik Screenshot_20210409-162649_Republik

ovbm commented 3 years ago

Linking needs to be tested more, agreed

ovbm commented 3 years ago

Deep linking works perfectly :), will merge and release as there hasn't been any reported issues.