reqnroll / Reqnroll.VisualStudio

Visual Studio extension for Reqnroll - open-source .NET BDD framework
https://reqnroll.net
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Fix unused step defs #24

Closed UL-ChrisGlew closed 1 month ago

UL-ChrisGlew commented 1 month ago

🤔 What's changed?

The 'Find Unused Step Definitions' context menu should no longer show step definitions decorated with the 'StepDefinition' attribute as unused when one or more is used with a Given/Then/When.

⚡️ What's your motivation?

Fix for #22.

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

I've attempted to add a new unit test to test this. This involved adding some logic to correctly add a 'StepDefinition' attribute into the 'MockableDiscoveryService' - let me know if there's any better way of doing this.

📋 Checklist:


This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

UL-ChrisGlew commented 1 month ago

@gasparnagy I've updated the Changelog with the requested changes.

gasparnagy commented 1 month ago

@UL-ChrisGlew I added you to the group already, but you still deserve the "official" intro: 😎 Thx for the help!

Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite