reqnroll / Reqnroll.VisualStudio

Visual Studio extension for Reqnroll - open-source .NET BDD framework
https://reqnroll.net
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Fix: Define Steps produces incorrect cucumber expression for step definition (#28) #29

Closed clrudolphi closed 1 month ago

clrudolphi commented 1 month ago

🤔 What's changed?

Modified the set of character escapes conducted within the CucumberExpressionSkeletonProvider such that the default set of characters needing escaping are escaped (such as was done within the Regex skeleton provider.

⚡️ What's your motivation?

This addresses the problem identified in GH28 in which empty parentheses resulted in an improper cucumber expression.

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

@gasparnagy please confirm that these character escapes won't cause other problems with Cucumber expressions and they remain compliant with Cucumber syntax and semantics.

📋 Checklist:


This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

clrudolphi commented 1 month ago

@gasparnagy please review. My regex skills are not as good as yours.