Add DateTimeOffsetValueComparer

cimnine commented 3 weeks ago

🤔 What's changed?

Adds a DateTimeOffsetValueComparer, fixes https://github.com/reqnroll/Reqnroll/issues/179.

⚡️ What's your motivation?

We mostly use DateTimeOffset instead of DateTime in our projects.

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] Users should know about my change
- [x] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

gasparnagy commented 3 weeks ago

@cimnine This makes sense. Could you please check the runtime test failures?

In general it is also worth noting that we did have a retriever for DateTimeOffset, but not a comparer (I don't know why).

cimnine commented 3 weeks ago

Could you please check the runtime test failures?

Done.

gasparnagy commented 3 weeks ago

@cimnine Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

reqnroll / Reqnroll