supported PriorityAttribute for MsTest #41

reqnroll / Reqnroll

Open-source Cucumber-style BDD test automation framework for .NET.

https://reqnroll.net

BSD 3-Clause "New" or "Revised" License

332 stars 37 forks source link

supported PriorityAttribute for MsTest #41 #42

Closed livioc closed 6 months ago

livioc commented 6 months ago

This pr adds the support for PriorityAttribute of the MsTest framework

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[ x] I've added tests for my code. (most of the time mandatory)
[ x] I have added an entry to the changelog. (mandatory)
[ x] My change requires a change to the documentation.
[ x] I have updated the documentation accordingly.

gasparnagy commented 6 months ago

Looks good, I like it.

@livioc Could you please include into the docs that the @priority: tag is only processed this way if there was a number provided after the :.

I think is is also important to mention because for anyone already had a @priority:high tag (it's quite common), there will be no breaking change (I mean no error of invalid priority format).

livioc commented 6 months ago

@gasparnagy I have pushed an updated version of the documentation

gasparnagy commented 6 months ago

Thx!

@livioc Would you be interested to also implement the [DataRow] attribute support as well? For xUnit and NUnit, SpecFlow (by default) generates a single parametrized test for scenario outlines and adds the examples as data rows. But for MsTest this was not implemented yet. (We should always keep the option to generate multiple methods, like we do for NUnit & xUnit.)

livioc commented 6 months ago

Thx!

@livioc Would you be interested to also implement the [DataRow] attribute support as well? For xUnit and NUnit, SpecFlow (by default) generates a single parametrized test for scenario outlines and adds the examples as data rows. But for MsTest this was not implemented yet. (We should always keep the option to generate multiple methods, like we do for NUnit & xUnit.)

@gasparnagy yes, I can work on it in the next weeks