search

reqnroll / Reqnroll

Open-source Cucumber-style BDD test automation framework for .NET.
https://reqnroll.net
BSD 3-Clause "New" or "Revised" License
312 stars 33 forks source link

Include BoDi to Reqnroll package (#91) #95

Closed gasparnagy closed 3 months ago

gasparnagy commented 3 months ago

A change to #80 Discussed in #91

gasparnagy commented 3 months ago

@mbhoek @ajeckmans Having slept on it... Why do we have it in a separate assembly at all? If we will never deploy BoDi separately and it is always needed, it should be in the Reqnroll.dll... What do you think?

Code-Grump commented 3 months ago

I didn't want to say the same for fear of it being too out there an idea, but embedding BoDi within the Reqnroll assembly makes total sense - it's practically an implementation detail.

mbhoek commented 3 months ago

@gasparnagy I'm fine with that, the only reason I kept it separate is because you asked me to in #40 😄

gasparnagy commented 3 months ago

@mbhoek @Code-Grump Yeah... That's why sleeping makes sense.

(A bit of history: BoDi was my first contribution to SpecFlow back in 2010 that I did in my free-time, because we were too busy at work and I could not progress with SpecFlow as I wanted. The "Bo" part of the "BoDi" name comes from the name of my first daughter, who way 1 year old at that time... Now she is 15 and in the national finals of the school programming contest, coding in Python and C++... :smile:)

ajeckmans commented 3 months ago

I didn't want to say the same for fear of it being too out there an idea, but embedding BoDi within the Reqnroll assembly makes total sense - it's practically an implementation detail.

I second that.