search

requarks / changelog-action

GitHub Action to generate changelog from conventional commits
MIT License
128 stars 41 forks source link

PR not detected #18

Closed jeacott1 closed 1 year ago

jeacott1 commented 1 year ago

I notice that in your latest version, referenced PR's are supposed to be linked in the changelog messages where they exist. Its not working for me. when I click on the sha link I get taken to a diff page where I can clearly see the PR ref in the corner (eg: main (#16) ), so it does exist. I'm wondering why my messages are of the format [e0d6403] - my message (commit by @someuser) and not including the PR ref?

I'm triggering the build:

on:
  create:

jobs:
   myjob:
    if: (contains(github.ref, '/tags/v'))
    ...
        id: changelog
        uses: requarks/changelog-action@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          fromTag: ${{ github.ref_name }}
          toTag: ${{ env.previousTag }}
          excludeTypes: ""
          writeToFile: false
NGPixel commented 1 year ago

Do you have an example repo / release with that behavior?

Here's a working example release with linked PRs: https://github.com/ietf-tools/datatracker/releases/tag/9.10.0

jeacott1 commented 1 year ago

I can see that its working for you, but it definitely isnt for me. I dont have a public repo example atm. have you tried triggering from on: create:? is that the difference?