Windows install script can't handle spaces within File Path

requarks / wiki-v1

Legacy version (1.x) of Wiki.js

https://wiki.js.org

GNU Affero General Public License v3.0

100 stars 75 forks source link

Windows install script can't handle spaces within File Path #124

Open HJain13 opened 6 years ago

HJain13 commented 6 years ago

Actual behavior

Path: E:\ABC\XYZ\Two Words\Test-Wiki
[1/6] Fetching 7zip helper... OK
[2/6] Fetching latest build... OK
[3/6] Fetching dependencies... OK
[4/6] Extracting app files...
ERROR: The system cannot find the file specified.
E:\ABC\XYZ\Two

Expected behavior

Two Words should be considered as the name of folder rather than Two

Steps to reproduce the behavior

Just add a space in Path where to install

NGPixel commented 6 years ago

It's generally best practice to avoid using spaces in paths. But I'll try to get it addressed for the 2.0 installation.