requarks / wiki-v1

Legacy version (1.x) of Wiki.js
https://wiki.js.org
GNU Affero General Public License v3.0
101 stars 75 forks source link

Config wizard errors when remote repository is empty #164

Closed Altreus closed 5 years ago

Altreus commented 5 years ago

Actual behavior

During configuration wizard, ability to pull master appears to be a heuristic for whether the remote git repository is working. It is necessary to create a dummy file in the repo before the wizard will complete.

Expected behavior

Wizard should expect remote repository to be new and thus not contain any refs.

Steps to reproduce the behavior

Wizard breaks at this point with error about remote ref master.

Wizard will now continue.

NGPixel commented 5 years ago

v1 requires the remote to be initialized first.

Upcoming v2 handles uninitialized repos correctly.