Uploading some JPEG files breaks git sync

[fpagnoux]

Actual behavior

When I update a specific JPEG file like this one[https://drive.google.com/file/d/1PQEfej2oB8XnLJrKBV_8lBFSf5dXhYhR/view?usp=sharing], the following happens:

• An error message appears on the website: "Unable to fetch updated listing." (as in #47)
• I get this error in the logs:

  Unhandled rejection TypeError: Corrupt JPG, exceeded buffer limits
  at validateBuffer (/webapps/bod-wiki/node_modules/image-size/lib/types/jpg.js:23:11)
  at Object.calculate (/webapps/bod-wiki/node_modules/image-size/lib/types/jpg.js:42:5)
  at lookup (/webapps/bod-wiki/node_modules/image-size/lib/index.js:26:31)
  at /webapps/bod-wiki/node_modules/image-size/lib/index.js:93:22
  at /webapps/bod-wiki/node_modules/image-size/lib/index.js:50:9
  at /webapps/bod-wiki/node_modules/graceful-fs/graceful-fs.js:43:10
  at FSReqWrap.oncomplete (fs.js:135:15)

• At this point, if I restart the instance, the git repository will not synchronize, probably because the agent stops after encountering the error above.

The root error probably comes from this issue which is not related to Wiki.js. But the fact that uploading an image ends up breaking the git sync is not really not ideal... Syncing with Git was one of the key features that made me choose Wiki.js, and it'd help if it was more robust and uncoupled from image processing.

Expected behavior

An issue processing an image should ideally not impact git synchronization

Steps to reproduce the behavior

See details above

[colo13c]

Hi, how do you fix it? I have the same issue and I dont know how to resolve it. Thanks anyway.

[fpagnoux]

I think I identified the problematic JPG, and re-uploaded them. That fixed the git sync for a while but then it broke again, not sure why. To avoid data losses I ended up adding a cron job that runs a git push every hour on the server. Sad to say but the git sync on wiki.js v1 is really not reliable. Not sure if things got better in the new version.