Convert Heroku environment variable to a proper boolean value before …

requarks / wiki-v1

Legacy version (1.x) of Wiki.js

https://wiki.js.org

GNU Affero General Public License v3.0

100 stars 75 forks source link

Convert Heroku environment variable to a proper boolean value before … #230

Open coreybutler opened 5 years ago

coreybutler commented 5 years ago

Forces the WIKIJS_HEROKU environment variable into a boolean state. Resolves #229.

AsierRF commented 5 years ago

Hello,

I was reviewing your changes and I saw that originally the code said:

if (process.env.WIKI_JS_HEROKU) {

However your changes use the following name for the env. variable: process.env.WIKIJS_HEROKU

The env. variable name is different: underscore (_) missing after WIKI.

Just wanted to verify that this is not a typo ;)

coreybutler commented 5 years ago

Good catch - that was a typo. Pretty sure I copied it out of the wrong container (I was working in two). Will update as soon as I get back to my computer.