requarks / wiki-v1

Legacy version (1.x) of Wiki.js
https://wiki.js.org
GNU Affero General Public License v3.0
100 stars 75 forks source link

Gracefully fail thumbnail generation #242

Closed pierreyves-lebrun closed 4 years ago

pierreyves-lebrun commented 5 years ago

Uploading images smaller than 150x150 pixels currently causes thumbnail generation to fail.

This issue has the side effect of preventing the folder tree view to render properly: if a folder called "images" contains a too small image, then only folders starting from letter 'a' to 'i' will show in the tree view. Other folders will be invisible from the folder tree.

This PR handles the case thumbnail generation fails, preventing the above side effect.