search

requarks / wiki-v1

Legacy version (1.x) of Wiki.js
https://wiki.js.org
GNU Affero General Public License v3.0
100 stars 75 forks source link

Issues with Google Login #40

Open ktechmidas opened 6 years ago

ktechmidas commented 6 years ago

Actual behavior

When we log in with Google ID with defaultReadAccess set to false the user gets the error "You are not authorized to access this page yet" - furthermore no user is created. With defaultReadAccess set to true, a user is created and the user can browse the wiki.

Expected behavior

The wiki should give a more helpful error message and create the user so the admin can authorize him/her.

Steps to reproduce the behavior

Set defaultReadAccess to false then try to login with a Google account.

NGPixel commented 6 years ago

This is as designed in 1.x. The goal is to prevent unauthorized users from creating unwanted accounts. Basically if I had a publicly accessible wiki and I'm using Google authentication to login, anybody could try to login and I would end up with a list of accounts I don't want.

The behavior will change a bit in 2.0 as users will be able to self-register (if enabled), which will enable what you are describing in "Expected behavior".

crackcomm commented 6 years ago

Similarly I got the same error when I expected to be connected to my account by email.