requarks / wiki

Wiki.js | A modern and powerful wiki app built on Node.js
https://js.wiki
GNU Affero General Public License v3.0
24k stars 2.63k forks source link

Git backend storage give-up on sync #2082

Open Lunik opened 4 years ago

Lunik commented 4 years ago

Describe the bug When Git backend storage fail for some reason (git server restarting for exemple), the storage function fail (obviously). But when the git service is back up, WikiJS never try to save again. It stay in error mode.

To Reproduce Steps to reproduce the behavior:

Additional steps :

Expected behavior

WikiJS should always try to sync even if the previous sync failed (maybe with a cooldown)

Screenshots N/A

Host Info (please complete the following information):

Additional context Add any other context about the problem here.

jmvaswani commented 7 months ago

Hi ! I would like to contribute to this issue, I currently have my dev environment setup, and I think I need to start off by learning about the scheduler that you guys use.

Can you please guide me to understanding the scheduler workflow? Also any info on the global WIKI object would be super helpful as well.. Thanks!

image

jmvaswani commented 7 months ago

Hey, I could not reproduce this problem on the development environment, any idea if it has been fixed? Perhaps we could close this issue

Steps performed by me 1) Set up git target 2) Run on default schedule (5M) 3) Cut off internet connectivity and observer failure 4) Restore connectivity and observed successful sync

image