requarks / wiki

Wiki.js | A modern and powerful wiki app built on Node.js
https://js.wiki
GNU Affero General Public License v3.0
24.45k stars 2.71k forks source link

Cannot display plantuml diagrams on markdown pages, but it works during edition #2687

Closed golflima closed 3 years ago

golflima commented 3 years ago

Describe the bug

We enabled the PlantUML renderer, and we use the default settings for it (using server https://www.plantuml.com/plantuml). When we create a Mardown page using a PlantUML diagram (with the block @startuml), we see on the editor the preview of the diagram. But when the page is saved, we only see the source code of the diagram.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new page using Markdown, when PlantUML renderer is enabled
  2. Save it
  3. Edit it, add a PlantUML diagram bloc, the preview renders it correctly while editing it
  4. Save the page
  5. View it: the PlantUML is rendered as a normal source code block, not as a diagram anymore.

Expected behavior

See the PlantUML rendered when viewing the page.

Logs

On the view page, I saw that the script https://wiki.domain.tld/_assets/js/prism/prism-plantuml.min.js was not found, it throws a 404. I checked in the container, and this file doesn't exists in the /wiki/assets/js/prism/ folder. Maybe an asset is missing in the Docker image?

Host Info (please complete the following information):

Thank you in advance guys for your support :)

fr34kyn01535 commented 3 years ago

Issue seems to persist, same here with Wiki.js 2.5.170 on Docker.