requarks / wiki

Wiki.js | A modern and powerful wiki app built on Node.js
https://js.wiki
GNU Affero General Public License v3.0
24.33k stars 2.69k forks source link

When setting a custom port via `node wiki configure`, doesn't use that port for fetching js files. #589

Closed fullykubed closed 6 years ago

fullykubed commented 6 years ago

Actual behavior

See title. Will load the initial request to custom port (in my case 3005). But the asset requests still go to localhost with no port extension.

screenshot from 2018-07-26 13-37-47

Expected behavior

Maybe I'm mistaken, but i'd expect them to go to the listening port?

Edit:

Ok. I think I figured it out. I had to specify the port in the url string as well as in the port input. It might be nice for it to be a little more clear that the url is the endpoint for a custom server OR the main wiki.js server. For whatever reason, I thought the input was simply requesting for the port to be a seperate from the url input. I'll leave this open (even though it is solved) as a potential enhancement. If you think the issue is just me being dumb, feel free to close it.

Steps to reproduce the behavior

gitbufenshuo commented 6 years ago

the same problem that i met;

omg. we should specify the host such as "http://xxxx.xxx.xxx:8000" while you should fill in the same port int the [port blank].