search

requery / sqlite-android

Android SQLite support library
Apache License 2.0
1.07k stars 143 forks source link

License information removed from artifacts #178

Open LeoColman opened 1 year ago

LeoColman commented 1 year ago

https://github.com/requery/sqlite-android/commit/bfd984ed94910935fbf15ab1bb242bbad2923950#diff-f89f2cd5186752f47b29318f8846e11017202f20e5e1f8426ee00b1a51ee8868L61-L78

This commit removed some bits that configured SQLite-Android artifact information directly. With this some tools that scan the artifact for licenses are failing to identify sqlite-android as open source.

Identified in: https://github.com/LeoColman/Petals/actions/runs/4512461828/jobs/7945969326#step:3:135

{ "dependenciesWithoutAllowedLicenses": [ { "moduleLicense": "", "moduleVersion": "3.41.1", "moduleName": "com.github.requery:sqlite-android" } ] }

Can we add those info back to the repository so that JitPack can include them?

npurushe commented 1 year ago

Thanks for reporting i'm not sure that is the commit that caused the problem since it only moved the metadata to a different part of the file. I think the with the maven publishing plugin that was added https://github.com/requery/sqlite-android/pull/180/files should be what is needed to resolve it.

LeoColman commented 1 year ago

Ah, I thought about that commit as it looked to be it changed nesting levels thus changing the target of that pom.

Thanks for the reply!

Mar. 29, 2023 03:32:39 Nikhil Purushe @.***>:

Thanks for reporting i'm not sure that is the commit that caused the problem since it only moved the metadata to a different part of the file. I think the with the maven publishing plugin that was added https://github.com/requery/sqlite-android/pull/180/files should be what is needed to resolve it.

— Reply to this email directly, view it on GitHub[https://github.com/requery/sqlite-android/issues/178#issuecomment-1488085245], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAMBCI3LBB6JWF3WCFJPCUDW6PQRLANCNFSM6AAAAAAWGVWMAY]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAMBCIZP2LALPHXHQALYJWTW6PQRLA5CNFSM6AAAAAAWGVWMA2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSYWJQP2.gif]