search

requery / sqlite-android

Android SQLite support library
Apache License 2.0
1.07k stars 142 forks source link

NO_LOCALIZED_COLLATORS missing? #97

Open githubber2222 opened 5 years ago

githubber2222 commented 5 years ago

strange... I used to use 3.15.1 and there I used NO_LOCALIZED_COLLATORS flag. Now I updated to latest version and this flag is gone!

Is there a replacement that I am missing? Or a workaround?

Current usage: 

SQLiteDatabase.openDatabase(path, null, SQLiteDatabase.OPEN_READONLY | SQLiteDatabase.NO_LOCALIZED_COLLATORS);
mikehardy commented 5 years ago

This is a dupe, but an interesting one I thought: https://github.com/requery/sqlite-android/issues/71

especially the maintainers reply https://github.com/requery/sqlite-android/issues/71#issuecomment-413110908

but the whole thing might be interesting as it had the steps necessary to bring the requery up to date in my app. There were at least 2 changes I needed

githubber2222 commented 5 years ago

OK, I guess from reading the other issue it seems like the lib now behaves the same way like I would expect when passing in the flag. In order for me to not having to change my code much I simply defined NO_LOCALIZED_COLLATORS in SQLiteDatabase with a value of 0. That way the ORing does nothing. I can keep it to show what I want the lib to do I guess and in case it ever is supported again I'm ready :-)

mikehardy commented 5 years ago

Just replying back to say that for full understanding, it seemed in the prior issue that it was never actually supported. You said "the lib now behaves" (emphasis added) which implies some change. The library always no-oped the flag, so no behavior change occurred. But future-proofing is I suppose a good thing, though I would expect a sem-ver compliant version change if localization ever happened since it would imply compatibility issues with on-device data