Wire the Yelp collector - Githubissues

request-yo-racks / api

A REST API for the Request-Yo-Racks projects.

https://api.requestyoracks.org

MIT License

0 stars 4 forks source link

Wire the Yelp collector #56

Closed rgreinho closed 6 years ago

rgreinho commented 6 years ago

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Code cleanup / Refactoring
Documentation

Description

Updates the Yelp client to match the new specification, especially the authentication using only an API key since March 1st 2018.

Updates the generic collector client to populate data into the BusinessInfo object and provide a better workflow for the devloppers.

Add/refactor unit tests
- Reach 100% coverage for Google collector
- Reach 100% coverage for Yelp collector
- Reach 100% coverage for Generic collector
- Reach 100% coverage for Base collector
Fixes the integration tests
Fix linter code violations
Consolidate collector function names
Update bootstrap script
Update deps
Split collector module
Improve workflow
Update docs

Motivation and Context

How Has This Been Tested?

With a lot of unit tests. Coverage is now 100%.

Checklist:

[X] I have updated the documentation accordingly
[X] I have written unit tests

Fixes request-yo-racks/api#24