request-yo-racks / api

A REST API for the Request-Yo-Racks projects.
https://api.requestyoracks.org
MIT License
0 stars 4 forks source link

Fix the Celery tasks and serializer #64

Closed rgreinho closed 6 years ago

rgreinho commented 6 years ago

Types of changes

Description

The default JSON serializer is not able to serialize complex objects like dates or dataclasses. This patch leverage json-tricks to serialize celery data instead of the python json serializer.

Motivation and Context

Make Celery work again with python 3.7 (and correctly!)

How Has This Been Tested?

Checklist:

codecov-io commented 6 years ago

Codecov Report

Merging #64 into master will increase coverage by 0.44%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   97.89%   98.34%   +0.44%     
==========================================
  Files           6        6              
  Lines         238      241       +3     
==========================================
+ Hits          233      237       +4     
+ Misses          5        4       -1
Impacted Files Coverage Δ
api/apps/api/collectors/generic.py 100% <100%> (ø) :arrow_up:
api/apps/api/collectors/base.py 100% <100%> (ø) :arrow_up:
api/apps/api/collectors/yelp.py 100% <100%> (ø) :arrow_up:
api/celery/tasks.py 87.5% <60%> (+2.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 610db65...5e8c57d. Read the comment docs.