search

request / aws-sign

AWS signing. Originally pulled from LearnBoost/knox, maintained as vendor in request, now a standalone module.
Apache License 2.0
29 stars 14 forks source link

Let's merge. #2

Closed domenic closed 11 years ago

domenic commented 11 years ago

I maintain knox, where this code is originally from. I just bugfixed our signing code (https://github.com/LearnBoost/knox/issues/149) and would love to give request those bugfixes too. Similarly, on NodeUp, I heard you had made bugfixes to this code that presumably never made it back into knox.

If you add me as a maintainer on GitHub and on npm, I'll take over maintenance of this project so you never have to worry about it again, and both request and knox can depend on it. I'll merge any bugfixes from both of our projects so that this repo contains the best of both. And I'll maintain semver guarantees to never break request if you depend on version 1.x; given this package's simplicity I doubt it will ever go beyond 1.x, but who knows.

You can also just transfer the repo to me if you want to never see GitHub notifications for it and keep it entirely out of sight, out of mind.

mikeal commented 11 years ago

Yes.

I'll add you as a maintainer for now but once we're all setup let's just transfer it to your github so it's domenic/aws-sign.