Removing lines 1127 to 1129

request / request

🏊🏾 Simplified HTTP request client.

Apache License 2.0

25.69k stars 3.15k forks source link

Removing lines 1127 to 1129 #3378

Open vrsbrazil opened 3 years ago

vrsbrazil commented 3 years ago

PR Checklist:

[X ] I have run npm test locally and all tests are passing.
[ ] I have added/updated tests for any new behavior.
[ X] If this is a significant change, an issue has already been created where the problem / solution was discussed: [ https://github.com/request/request/issues/3365 ]

PR Description

After analysis on issue #3365 was not able to find a direct use for these lines of code and it actually would raise ERR_STRING_TOO_LONG on large file downloads.

mrkmg commented 3 years ago

After a quick glance, this would be a breaking change if one was to expect response.body to be a string but actually received a buffer.