request / request

🏊🏾 Simplified HTTP request client.
Apache License 2.0
25.67k stars 3.14k forks source link

Compliance: APL 2.0 should have a NOTICE file #3438

Open lucasgonze opened 1 year ago

lucasgonze commented 1 year ago

Summary

The Apache 2.0 license is different than MIT in that the copyright statement and license go into different files. The copyright statement goes in a file named NOTICE, the license goes into a file named LICENSE. See https://www.apache.org/legal/src-headers.html#notice

The request repo does not have any NOTICE file. Including your NOTICE file is a requirement of the license. So downstream dependents are not able to comply with the terms of your lcense.

Possible Solution

Create a file named NOTICE at the root of the rep with contents along these lines: (from https://www.apache.org/legal/src-headers.html#notice)


Apache [PRODUCT_NAME]
Copyright [XXXX-XXXX] The Apache Software Foundation

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).