search

requestly / requestly-desktop-app

Requestly Desktop App (Mac, Linux, Windows)
https://requestly.com
GNU Affero General Public License v3.0
50 stars 12 forks source link

RQLY-1153 upgrade dependencies #23

Closed nsrCodes closed 1 year ago

nsrCodes commented 1 year ago

Fixed all audit bugs

Updates release pipeline node version to 16.15.0

Known issue introduced - signing and afterSign not triggered This is because earlier, electron-builder's afterSign hook was faulty and would also trigger when wrongly configured (which I guess is the case in our application). Reference - https://github.com/electron-userland/electron-builder/pull/7311 The build is still notarized (requires an extra APPLE_APP_SPECIFIC_PASSWORD environment variable) but not signed. As a result of this erb's notarize.js is not executed.

nsrCodes commented 1 year ago

Removed win-detect-browser patch because it is no longer needed.

Linux action still fails when the release/app does not have node modules. Need to fix the workflow for that. Completely tested on windows and linux