requestly / requestly-desktop-app

Requestly Desktop App (Mac, Linux, Windows)
https://requestly.io/
GNU Affero General Public License v3.0
45 stars 10 forks source link

[Snyk] Security upgrade mockttp from 2.5.1 to 3.4.0 #85

Closed Dinex-dev closed 5 months ago

Dinex-dev commented 5 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - release/app/package.json - release/app/package-lock.json #### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Priority Score (*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- ![critical severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/c.png "critical severity") | **811/1000**
**Why?** Proof of Concept exploit, Has a fix available, CVSS 9.8 | Remote Code Execution (RCE)
[SNYK-JS-VM2-5772823](https://snyk.io/vuln/SNYK-JS-VM2-5772823) | Yes | Proof of Concept ![critical severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/c.png "critical severity") | **876/1000**
**Why?** Mature exploit, Has a fix available, CVSS 9.8 | Remote Code Execution (RCE)
[SNYK-JS-VM2-5772825](https://snyk.io/vuln/SNYK-JS-VM2-5772825) | Yes | Mature (*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: mockttp The new version differs by 147 commits.
  • 7ef9365 3.4.0
  • 7b5d0c4 Omit invalid upstream response headers during proxying
  • cfce946 Allow providing a CA in proxy config, to configure HTTPS proxy CA trust
  • 1c816a0 Fix bug where including auth params in a proxy URL broke all connections
  • fe308ab More clearly abort refused connections downstream
  • 8fad51a Add JSON-RPC matcher & handler methods
  • 9b3cca6 Relicense as Apache-2.0 for consistency with other projects
  • 04c5320 Correctly use regex flags in regex path matching
  • a1d9231 Update parse-multipart-data to avoid sourcemap warning & assorted bugs
  • fa5bd2b 3.3.1
  • ae41416 Share 'no fail on server issues' logic from JA3 tests with lintcert tests
  • bc1c129 Update user agent in TLS JA3 test
  • dace568 Don't replace body when using matchReplaceBody if there were no matches
  • 3fe388c Automatically handle invalid _ DNS via wildcards for TLS certs
  • c1f7cd3 Make JA3 test stable despite test server fragility
  • 8ca1cd7 Pin portfinder dep to avoid recent TS breakage
  • 2d75a34 3.3.0
  • 332085f Stop forwarding the proxy-connection header, to avoid traffic blocking
  • f7c6dc9 Run CI against the new server preferred Node.js version
  • 118189c Improve TLS fingerprint behaviour for upstream connections
  • 909c2a9 3.2.3
  • 8ce44c0 Include the session id in mock-session-{started,stopped} events
  • a1e2404 3.2.2
  • 19bfe71 Fix bug in MockttpClient admin client lifecycle event subscriptions
See the full diff
Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: šŸ§ [View latest project report](https://app.snyk.io/org/sagar-r2x/project/ae0388a3-d7b1-49b0-b62a-b6125113feab?utm_source=github&utm_medium=referral&page=fix-pr) šŸ›  [Adjust project settings](https://app.snyk.io/org/sagar-r2x/project/ae0388a3-d7b1-49b0-b62a-b6125113feab?utm_source=github&utm_medium=referral&page=fix-pr/settings) šŸ“š [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"be5a20ec-ec12-40fb-8a56-fd7c19c60181","prPublicId":"be5a20ec-ec12-40fb-8a56-fd7c19c60181","dependencies":[{"name":"mockttp","from":"2.5.1","to":"3.4.0"}],"packageManager":"npm","projectPublicId":"ae0388a3-d7b1-49b0-b62a-b6125113feab","projectUrl":"https://app.snyk.io/org/sagar-r2x/project/ae0388a3-d7b1-49b0-b62a-b6125113feab?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-VM2-5772823","SNYK-JS-VM2-5772825"],"upgrade":["SNYK-JS-VM2-5772823","SNYK-JS-VM2-5772825"],"isBreakingChange":true,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","priorityScore"],"priorityScoreList":[811,876],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** šŸ¦‰ [Remote Code Execution (RCE)](https://learn.snyk.io/lesson/malicious-code-injection/?loc=fix-pr)
nsrCodes commented 5 months ago

As mentioned here - https://github.com/requestly/requestly-desktop-app/pull/83#issue-2201609753 Will require major consideration of if the proxy can work with the breaking changes.