search

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests
MIT License
121 stars 21 forks source link

Add optional type hint for DynamoDB context #176

Closed mjkanji closed 1 year ago

mjkanji commented 1 year ago

The context argument for DynamoDBBackend was missing a type hint.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ecf65c8) 96.87% compared to head (e3a3547) 96.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #176 +/- ## ======================================= Coverage 96.87% 96.87% ======================================= Files 10 10 Lines 927 927 Branches 167 167 ======================================= Hits 898 898 Misses 18 18 Partials 11 11 ``` | [Files Changed](https://app.codecov.io/gh/requests-cache/aiohttp-client-cache/pull/176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=requests-cache) | Coverage Δ | | |---|---|---| | [aiohttp\_client\_cache/backends/dynamodb.py](https://app.codecov.io/gh/requests-cache/aiohttp-client-cache/pull/176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=requests-cache#diff-YWlvaHR0cF9jbGllbnRfY2FjaGUvYmFja2VuZHMvZHluYW1vZGIucHk=) | `96.66% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JWCook commented 1 year ago

Good catch, thank you!