search

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests
MIT License
116 stars 20 forks source link

Add custom test server and additional test for conditional requests. #198

Closed netomi closed 10 months ago

netomi commented 10 months ago

This fixes #196 .

This adds a test server that will be run using gunicorn either during the build workflow or as a separate docker image when testing locally using docker-compose.

Please take a look, if you are not happy with the solution and would like to embed it directly into the test suite I would also be fine with that ofc.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8ce8498) 96.04% compared to head (84fd22e) 96.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== + Coverage 96.04% 96.75% +0.70% ========================================== Files 10 10 Lines 986 986 Branches 182 182 ========================================== + Hits 947 954 +7 + Misses 25 19 -6 + Partials 14 13 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/requests-cache/aiohttp-client-cache/pull/198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=requests-cache)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JWCook commented 10 months ago

This looks good to me. Thank you very much for putting this together!