search

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests
MIT License
116 stars 20 forks source link

Add a DragonflyDB container and related instructiond to the documentation #211

Closed alessio-locatelli closed 8 months ago

alessio-locatelli commented 8 months ago

Currently, I think running DragonflyDB in CI is overkill, unless someone specifically asks for it.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1faf1b2) 96.96% compared to head (26c61ea) 96.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ======================================= Coverage 96.96% 96.96% ======================================= Files 10 10 Lines 988 988 Branches 180 180 ======================================= Hits 958 958 Misses 18 18 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JWCook commented 8 months ago

Cool this was on my list of things to try out. Did you happen to run any benchmarks to see if there's much of a performance difference?

alessio-locatelli commented 8 months ago

Cool this was on my list of things to try out. Did you happen to run any benchmarks to see if there's much of a performance difference?

I have not written any real benchmarks but I have tried simple things like set/get 1000 values and I see no difference. I recommend writing some good real benchmarks if anyone is thinking of switching to Dragonfly.