Make `try_int` safer and add a test for it

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests

MIT License

118 stars 20 forks source link

Make `try_int` safer and add a test for it #216

Closed alessio-locatelli closed 9 months ago

alessio-locatelli commented 9 months ago

What

Now it is clear what is and is not accepted by the function.
Previously, float and bool could be silently converted to None. Since this is not safe and does not match the function description, float and bool are now not accepted.
Added a test.

Are there breaking changes? Are users affected?

No.

Update 1

Sadly, | and typing.Union are unsupported with @singledispatch in older Python versions. I had to downgrade the code and use a much longer syntax.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87e5732) 96.96% compared to head (cafed60) 97.02%. Report is 3 commits behind head on main.

:exclamation: Current head cafed60 differs from pull request most recent head bf54a5c. Consider uploading reports for the commit bf54a5c to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== + Coverage 96.96% 97.02% +0.06% ========================================== Files 10 10 Lines 988 1008 +20 Branches 166 172 +6 ========================================== + Hits 958 978 +20 Misses 19 19 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.