search

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests
MIT License
121 stars 21 forks source link

Override __aenter__ for CachedSession #219

Closed rudcode closed 9 months ago

rudcode commented 9 months ago

Typechecking complaint about it being ClientSession, so override it to return CachedSession itself.

Or is it intentional to return it as ClientSession?

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ce8b18a) 97.22% compared to head (04e103d) 97.23%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #219 +/- ## ======================================= Coverage 97.22% 97.23% ======================================= Files 10 10 Lines 1009 1011 +2 Branches 172 172 ======================================= + Hits 981 983 +2 Misses 18 18 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JWCook commented 9 months ago

Looks good to me. Thanks!