Update Mypy config and type annotations

requests-cache / aiohttp-client-cache

An async persistent cache for aiohttp requests

MIT License

116 stars 20 forks source link

Update Mypy config and type annotations #220

Closed alessio-locatelli closed 7 months ago

alessio-locatelli commented 7 months ago

Breaking changes

Other notes

I looked at https://github.com/requests-cache/aiohttp-client-cache/commit/e43d75148ce5edcd52356e4985c27d0af855a300 where you added

        if isinstance(client_response, cls):
            return client_response

but I was not able to reproduce why or when these lines can be triggered or used.

Changelog

I will update in a next PR.

Next steps

I was going to include check_untyped_defs = true in this PR, but it raises too many warnings, so I prefer to create a dedicated PR.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ce8b18a) 97.22% compared to head (6f8b5bf) 97.22%. Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #220 +/- ## ======================================= Coverage 97.22% 97.22% ======================================= Files 10 10 Lines 1009 1010 +1 Branches 172 171 -1 ======================================= + Hits 981 982 +1 Misses 18 18 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JWCook commented 7 months ago

Thanks! I like these settings. I should've been using these a long time ago!