requests / requests-kerberos

An authentication handler for using Kerberos with Python Requests.
Other
289 stars 101 forks source link

Cannot Install on OSX 12 #161

Closed tasdrake closed 3 years ago

tasdrake commented 3 years ago

Pykerberos is no longer maintained and cannot be installed on OSX 12. The repository recommends using Apple's maintained version of pykerberos, which can be installed on OSX 12.

jborean93 commented 3 years ago

Honestly at this point neither the Apple pykerberos or the fork should be used. Instead the python-gssapi library is far more preferable and is maintained plus has a higher quality of code compared to the current ones being proposed. I could even submit a PR that uses my pyspnego which wraps both python-gssapi and an SSPI extension and unifies it in 1 API. I could also just bypass that and have this library call python-gssapi and some Windows support Kerberos implementation like winkerberos, pywin32, something else as well but that would be more work as pyspnego already does that.

@behackett I know you maintain the winkerberos library, would you be ok with dropping that in favour of pyspnego or even pywin32 which exposes the SSPI API as is rather than the pykerberos like interface that winkerberos uses?

behackett commented 3 years ago

I wrote WinKerberos for use in PyMongo, where it serves MongoDB well. I'm glad it helped this project too, but I won't feel bad if you switch implementations. Thanks for thinking of me though. :-)

jborean93 commented 3 years ago

Thanks for confirming @behackett. I've opened https://github.com/requests/requests-kerberos/pull/163 which includes the conversion to pyspnego. I'm planning on doing some more tests to make sure nothing major has broken but so far the tests pass.

jborean93 commented 3 years ago

Implemented with https://github.com/requests/requests-kerberos/pull/163.

jborean93 commented 3 years ago

The changes have been published under 0.13.0rc1 on PyPI for testing.