search

requests / requests-kerberos

An authentication handler for using Kerberos with Python Requests.
Other
289 stars 101 forks source link

Change underlying lib to pyspnego #163

Closed jborean93 closed 3 years ago

jborean93 commented 3 years ago

This changes the underlying Kerberos library from pykerberos and winkerberos to pyspnego. The pyspnego library handles the platforms differences between Windows and Linux meaning there is now only 1 dependency.

Some other changes being made is designed to hide the underlying library used a bit more to avoid external libraries using it for their own purposes. This will ensure the kerb library can easily be changed in the future if need be.

The tests have been turned into pytest tests as a few of the mocking functions needed to be changed due to the new API of pyspnego compared to the existing ones.

jborean93 commented 3 years ago

Will need some more practical testing before this is merged.

jborean93 commented 3 years ago

Have tested the changes from both a Linux, macOS, and Windows host against a Kerberos auth'd HTTP backend without any issues. Will release an rc of 0.13.0 just to be sure but things look like they work.