Closed metadaddy closed 2 years ago
Changes look good.
Test failures do not appear to be related to this patch.
Would love to see this get merged, bringing requests-oauthlib into compliance with the spec.
A lot of services seem to silently accept the extra and erroneous data at the end of the Content-Type header, but it should be on the Oauth2 libraries implementing the spec to maintain compliance, and not on the Oauth2 providers.
Would love to see this get merged, bringing requests-oauthlib into compliance with the spec.
A lot of services seem to silently accept the extra and erroneous data at the end of the Content-Type header, but it should be on the Oauth2 libraries implementing the spec to maintain compliance, and not on the Oauth2 providers.
Noted. Some of us are working on getting the pipeline up to date, providing a good foundation to bring in contributions again. Will keep an eye on this PR. TY.
LGTM
The WHATWG URL Standard unambiguously defines the
application/x-www-form-urlencoded
format, its parsing and encoding (which includes UTF-8, but applies additional steps). Consequently, no charset is required, or indeed permitted, with theapplication/x-www-form-urlencoded
content type, and supplying one causes issues with some authorization servers.