Release 1.3.1 - Githubissues

requests / requests-oauthlib

OAuthlib support for Python-Requests!

https://requests-oauthlib.readthedocs.org/

ISC License

1.72k stars 424 forks source link

Release 1.3.1 #480

Closed JonathanHuot closed 2 years ago

JonathanHuot commented 2 years ago

After this MR is OK, we can tag the git commit, and it should (hopefully) automatically push the python package to pypi. Have a look on changelog & new pipeline.

coveralls commented 2 years ago

Coverage remained the same at 90.239% when pulling bcbb876567ad03a476095bdbeb7e39816a535b2e on release-1.3.1 into 05a25a96522dc64c25224a4862f2342a6978e80d on master.

JonathanHuot commented 2 years ago

Note that I avoided adding the automatic Github Release publishing, as I have too many Github Actions related to this... I was not able to choose, as none of them seems complete!

Basically, I was trying to replace the lovely TravisCI "releases" provider:

deploy:
  - provider: releases
    api_key:
      secure: "<..>"
    on:
      tags: true
      all_branches: true
      condition: $TOXENV = py36
      repo: requests/requests-oauthlib

JonathanHuot commented 2 years ago

Pushing tag triggered the release in pypi as expected ! https://pypi.org/project/requests-oauthlib/1.3.1/

jtroussard commented 2 years ago

I think we need to rethink our code coverage check, there is a bug I think on coverall side that causing these -0% coverage changes and creates these merge blocks. These are a few options:

workaround this and increase request-oauthlib coverall threshold to something like 0.01%
don't check all versions of python for coverage - should only really check for maintained and/or supported versions (this could still leave us with a version that is returning the -0% change)
Only run coverage against the latest version of python

https://github.com/lemurheavy/coveralls-public/issues/1608#issuecomment-1005177210

@JonathanHuot

jtroussard commented 2 years ago

@JonathanHuot - Circling back to this one here. Just needs a nudge to get it across the finish line. Who has access to the coveralls settings? Can we bump the coverage check threshold to 0.01% and run the pipeline against this release again?

JonathanHuot commented 2 years ago

thanks to @nateprewitt, the coverage threshold has been changed to 1%, and now all checks are passing!

@jtroussard, the story about restoring pipeline is done finally. Now we can focus on bug & features PR reviews..