search

requests / requests-oauthlib

OAuthlib support for Python-Requests!
https://requests-oauthlib.readthedocs.org/
ISC License
1.72k stars 424 forks source link

Version 1.3.1 removed module compliance_fixes.linkedin #483

Open den4uk opened 2 years ago

den4uk commented 2 years ago

The latest release (1.3.1) has a missing module for linkedin compliance fixes.

ImportError: cannot import name 'linkedin_compliance_fix' from 'requests_oauthlib.compliance_fixes'

v1.3.0 still has it: https://github.com/requests/requests-oauthlib/blob/v1.3.0/requests_oauthlib/compliance_fixes/linkedin.py

The removal without a deprecation caused undesired side effects. So far, I managed to catch the change in unit tests, however, expect it to cascade for the rest of the world 🌎 📉

JonathanHuot commented 2 years ago

Agreed the version should have been bumped to 1.4.0 instead. It has been missed somehow. Or a deprecation is also a good idea.

Note that the linkedin seems no longer required as described here https://github.com/requests/requests-oauthlib/pull/397

den4uk commented 2 years ago

Thanks for acknowledgement. Given the breaking changes, this should have really better been a 2.0. It is what it is now. I hope there aren't too many fires out there :)

jtroussard commented 2 years ago

@JonathanHuot @den4uk Would it be problematic to release a quick patch? Revert the removal, and add a deprecation warning. Removal can return for 1.4. Or is this too much of a snip snap situation? #485 ???

JonathanHuot commented 2 years ago

Since you already have done all the work @jtroussard, I think it is a reasonable ask :) Let's me take care of it.