search

requests / requests-oauthlib

OAuthlib support for Python-Requests!
https://requests-oauthlib.readthedocs.org/
ISC License
1.71k stars 421 forks source link

Revert 397 and add Deprecation warning instead #485

Closed jtroussard closed 5 months ago

jtroussard commented 2 years ago

Semantic version mistake was made when releasing 1.3.1, the Linkedin compliance fix which was removed from the code base, api breaking change, did not trigger a main version release increment. e.g. 1.4 instead of 1.3.1.

This PR reverts the Linkedin compliance hook removal, and instead adds a deprecation warning. Can remove next major version release. Return Linkedin example file to original state as well as bringing back unit tests.

Updates HISTORY and AUTHOR file.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.3%) to 90.637% when pulling 16a3473e47d992f16497eb6088e209a075691cc7 on revert-397 into b3decdb65872ba1f59b65f62406949306b673ddb on master.

jtroussard commented 2 years ago

@JonathanHuot we good now?

JonathanHuot commented 2 years ago

For hotfix, I think we should merge into master only after the release of v1.3.2.

So basically, I will suggest to raise PR to merge your changes into the release-1.3.2 branch (just created now based on v1.3.1 tag).

Once your changes merged and reviewed, we can push tag v1.3.2 and that will trigger the release to pypi.

Once released and happy, we can merge release-1.3.2 into master to target 1.4.x.

JonathanHuot commented 5 months ago

Closed as no time to fix backward the version to maintain version semantic.