SourceAddressAdapter with certain port should be stricter with pool size and blocking?

requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests

https://toolbelt.readthedocs.org

Other

998 stars 186 forks source link

SourceAddressAdapter with certain port should be stricter with pool size and blocking? #330

Open n1ngu opened 2 years ago

n1ngu commented 2 years ago

As far as I understand, if SourceAddressAdapter is used with an (IP, PORT) tuple and the port is other than 0, there is no way this adapter can work without passing

pool_connections=1,
pool_maxsize=1,
pool_block=True,

to the underlying HTTPAdapter.

Shouldn't this either

be forced by the implementation
raise a warning if this exact values are not specified by the user
write more documentation about it