search

requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests
https://toolbelt.readthedocs.org
Other
989 stars 186 forks source link

Remove `BaseURLSession.request` method #347

Closed luhn closed 1 year ago

luhn commented 1 year ago

Session.request calls prepare_request, so BaseURLSession.request is redundant with BaseURLSession.prepare_request.

sigmavirus24 commented 1 year ago

Except that people tend to inherit from this and do other things that are not advisable. This is a safety precaution after bugs/emails of "when I replace prepare request it doesn't work", so redundancy doesn't hurt in a library like this