search

requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests
https://toolbelt.readthedocs.org
Other
989 stars 186 forks source link

Documentation out of date? #348

Closed loucadufault closed 1 year ago

loucadufault commented 1 year ago

Not sure why, but the documentation for this package on https://toolbelt.readthedocs.io/en/latest/ seems to be trailing the latest release (0.10.1). As such, there are bugs such as this one: #259 that are still present in the docs years later.

Is this a known issue?

pquentin commented 1 year ago

I'm aware of this, but need @sigmavirus24 to give me (pquentin) access to the docs for me to fix it.

sigmavirus24 commented 1 year ago

Sent you the invite @pquentin .

I suspect I'll need to elevate your privileges on the repo too in order to settle this, but I'm still mostly operating from a phone these days. Let me know if you need additional permissions

pquentin commented 1 year ago

@loucadufault Thanks to @sigmavirus24, https://toolbelt.readthedocs.io/en/latest/ is now up-to-date.

However, releases won't have any effect as the fix was a manual build and the GitHub webhook is gone. I tried adding it in https://readthedocs.org/dashboard/toolbelt/integrations/ but I don't have the necessary GitHub permissions. @sigmavirus24 Would you mind adding it or figuring out how to elevate my GitHub privileges? (The next step will be to configure Read the Docs to build on pull requests.)

sigmavirus24 commented 1 year ago

I think you should be good now @pquentin

pquentin commented 1 year ago

Thanks, the integration is in place, closing.