requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests
https://toolbelt.readthedocs.org
Other
989 stars 186 forks source link

Remove Google AppEngine support #355

Closed pquentin closed 1 year ago

pquentin commented 1 year ago

Relates https://github.com/requests/toolbelt/issues/354

It's not the only change required to support urllib3 2.0, but it's a first step.

sigmavirus24 commented 1 year ago

Can we also add a 1.0 section to HISTORY.rst with this removal called out under a Breaking Changes section?

gianpaj commented 1 year ago

For others who might be using packages that depend on requests-toolbelt and start getting these errors:

/lib/python3.10/site-packages/requests_toolbelt/adapters/appengine.py", line 42, in <module>
    from .._compat import gaecontrib
ImportError: cannot import name 'gaecontrib' from 'requests_toolbelt._compat' (/venv/lib/python3.10/site-packages/requests_toolbelt/_compat.py)

I managed to fix this by downgrading to the previous version

requests-toolbelt==0.10.1

Not sure if related but I'm still using urllib3==1.26.7

I'm using pyrebase, a wrapper for the Firebase API.