requests / toolbelt

A toolbelt of useful classes and functions to be used with python-requests
https://toolbelt.readthedocs.org
Other
989 stars 186 forks source link

Making releases with changelog #362

Closed leszekhanusz closed 1 year ago

leszekhanusz commented 1 year ago

I'm investigating issue 412 of gql and was interested to know if there was any breaking change with version 1.0 Usually you should find this information in the releases tab of GitHub but it does not seem to be there.

Could you please make releases with changelogs so that users could know what has changed between versions?

Thanks!

sigmavirus24 commented 1 year ago

No. There's already a changelog in the documentation. Creating releases on GitHub is unnecessary additional work and creates issues when users try to install from the generated artifacts.

leszekhanusz commented 1 year ago

That's not a nice answer. The least you could do is point me to where I can find that changelog. Looking for changelog in your doc does not find anything and you don't have a CHANGELOG.rst file either.

I'm also a maintainer (of gql) and it's really not a lot of work to do it.

̶W̶h̶e̶r̶e̶ ̶c̶a̶n̶ ̶I̶ ̶f̶i̶n̶d̶ ̶t̶h̶i̶s̶ ̶c̶h̶a̶n̶g̶e̶l̶o̶g̶?̶ Nevermind, I found it, it is in HISTORY.rst :facepalm:

sigmavirus24 commented 1 year ago

That's not a nice answer.

If you think someone telling you no is not nice, I'm not sure what else to do for you. Not accepting no as an answer is a very good way to end up violating another person's boundaries and is a large red flag.