requiemofthesouls / pigeomail

✉️ Service which provides securely personal email addresses right in telegram
https://t.me/PigeomailBot
Apache License 2.0
6 stars 2 forks source link

Ignore when a non-command string typed in chat #17

Closed arvryna closed 1 year ago

arvryna commented 2 years ago

Describe the bug when you type something that is not a command, a message is shown as "Internal error, please try again later..."

Expected behavior Hide that message

Screenshots image

arvryna commented 2 years ago

Fix: is it okay to just remove the line 21 ? or should it be handled in a different way ?

image

requiemofthesouls commented 2 years ago

Fix: is it okay to just remove the line 21 ? or should it be handled in a different way ?

image

we need to handle database err not found error and if it's not found error - just ignore user message. if other error - send it to sentry in future

arvryna commented 2 years ago

okay, i will create a sentry account and send logs there. Each and every logs must go there ?

requiemofthesouls commented 2 years ago

okay, i will create a sentry account and send logs there. Each and every logs must go there ?

add sentry in docker compose and send only errors there

arvryna commented 2 years ago

need a clarification = " add sentry in docker compose" .. you mean to add the self-hosted version of sentry service running in our server OR you just want to use only the api-key, install sentry go-sdk and get started ?

requiemofthesouls commented 2 years ago

need a clarification = " add sentry in docker compose" .. you mean to add the self-hosted version of sentry service running in our server OR you just want to use only the api-key, install sentry go-sdk and get started ?

we can start from SaaS version, self-hosted will be installed if free plan will be expired

requiemofthesouls commented 2 years ago

okay, i will create a sentry account and send logs there. Each and every logs must go there ?

add sentry in docker compose and send only errors there

just realized that we don't need self hosted sentry yet

arvryna commented 2 years ago

yes. btw, planning to implement this way:

step 1) create a folder in root called monitoring->sentry->sentry.go (which will contain New() func) that will set the key and return sentry object

step 2) call the New() function from step1 in tg_bot.go and receiver.go and pass it as part of constructors - NewSMTPReceiver & NewTGBot

requiemofthesouls commented 2 years ago

@arvryna alright

requiemofthesouls commented 2 years ago

actual behaviour image