search

requilence / integram

Integrate Telegram into your workflow – Trello, Gitlab, Bitbucket and other bots
https://integram.org
GNU General Public License v3.0
1.54k stars 151 forks source link

[Enhancement] Improve message format on commit #27

Closed biels closed 6 years ago

biels commented 7 years ago

You should look at the bot @GitHubBot and see how it displays commit and issue messages. image I am using Integram with Bitbucket. The main problem is that if you provide a direct url, telegram renders it along with a giant profile picture on mobile devices. This quickly floods development groups.

I think implementing an output format like the one above shouldn't be difficult at all. If you point me in the right direction I could even make a pull request for you. Thanks!

Edit: Took a look at the code, the changes should be made around here: https://github.com/Requilence/integram/blob/master/services/bitbucket/webhook.go#L340

requilence commented 7 years ago

Hi! This was not a bug but feature 😀 But I agree with you. The commit messages should be more compact. I fixed that @f8a992dc48002089b4533175c9e1cde2610c0621 and deployed to production

biels commented 7 years ago

Wow! Tanks for the quick fix! Tested it and looks way better. For now, closing. If I see something else or have another idea I will create another issue for that.

biels commented 6 years ago

This issue is not fixed yet for more than one commit in the same push. The message gets really messy. Could the design be like the one posted in the first issue?

[commit 1 hash with link]: [Message] by [User name] [commit 2 hash with link]: [Message] by [User name] [commit n hash with link]: [Message] by [User name] And if the message starts to get past a certain length then start doing ellipsis on commit messages and finally if there are more than n commits (for example 6) add "and n more" with a link to commits page.

It think it's a great way to improve integram with very little effort!