search

requilence / integram

Integrate Telegram into your workflow – Trello, Gitlab, Bitbucket and other bots
https://integram.org
GNU General Public License v3.0
1.54k stars 151 forks source link

GitLab should not notify an unsuccessful build if allow_failure is enabled #40

Closed erickskrauch closed 7 years ago

erickskrauch commented 7 years ago

Hi. We use your tool and that's cool, but for one of the projects we have this config:

test_jre7:
  <<: *test_definition
  image: openjdk:7-jdk-alpine

test_jre8:
  <<: *test_definition
  image: openjdk:8-jdk-alpine

# Allow failure, until https://github.com/docker-library/openjdk/issues/101#issuecomment-312510546
test_jre9:
  <<: *test_definition
  image: openjdk:9-jdk
  allow_failure: true

As you can see, task for jre9 have allow_failure: true, because some Java 9 bug (not ours, honestly). But the bot continues to send a notification that this task has been failed:

If this is possible, please, add an option or enable it by default to do not receive such notifications for suppressed tasks.

requilence commented 7 years ago

HI! Thanks for reporting. Should be fixed by 9741c2d62142505503657f10d2273b9aad29a83d. Already on production

erickskrauch commented 7 years ago

Thanks! It's worked: