jrburke
commented
9 years ago Ah, the travis ci integration failed due to travis being down, but this looks reasonable, so merging, we can always fix if it was not correct.
Closed cstickel closed 9 years ago
jrburke
commented
9 years ago Ah, the travis ci integration failed due to travis being down, but this looks reasonable, so merging, we can always fix if it was not correct.
cstickel
commented
9 years ago Hurm, all current pull requests beside this one, which fixed the problem, failed in travis ci. I don't think that it was always down. It was really because the line of .travis.yml "node tests/server.js" could not be executed. That's also what the travis log says. And it was also true on local machines, if someone tried to run tests there via phantomjs. Btw is there a reason this pull request got merged but #105 did not, yet? Does it has something to do with failing travis ci? In that case I would merge this change into the pull request branch and push that commit to just retrigger a successful travis ci run.
jrburke
commented
9 years ago Yeah I think travis just when down for a moment. As to #105, I'll need more time to study it, compare to what requirejs does internally, make sure that a similar failure is not there since at one time they shared some of this code. It may not be until the weekend before I get to it, but I do appreciate you taking the time to do a pull request, and for sorting out the travis stuff!
cstickel
commented
9 years ago Ah, ok.. don't hurry, I just wanted to get sure, that nothing from my side is blocking the process.
Npm configuration was configured to always install newest connect version. Since they changed connect API from version 2.x to 3.x the tests/server.js file was not working anymore. Therefore travis CI could not successfully run through the builds. The problem should be fixed and npm is configured to update only minor connect releases, to prevent similar problems in future.